[improvement](be) Avoid eager formatting in hot paths - #66366
Open
Mryange wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#66363 Problem Summary: Successful delete bitmap cache checks repeatedly traversed both bitmaps to construct an unused error message, and nullable LARGEINT Arrow serialization formatted values before checking whether rows were null. Reuse the computed bitmap cardinalities, construct the mismatch message only on failure, and format LARGEINT values only for non-null rows. ### Release note None ### Check List (For Author) - Test: No need to test (control flow-only optimization; clang-format and git diff checks completed) - Behavior changed: No - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
TPC-H: Total hot run time: 29190 ms |
Contributor
TPC-DS: Total hot run time: 169431 ms |
Contributor
ClickBench: Total hot run time: 23.91 s |
Contributor
|
/review |
HappenLee
reviewed
Aug 5, 2026
| "delete bitmap cache check failed, cur_cardinality={}, cached_cardinality={}" | ||
| "txn_id={}, tablet_id={}", | ||
| expected_delete_bitmap->cardinality(), cached_delete_bitmap->cardinality(), txn_id, | ||
| tablet_id()); |
Contributor
There was a problem hiding this comment.
错误字符串中 cached_cardinality={} 与 txn_id={} 之间缺少逗号或空格，最终会输出成
cached_cardinality=10txn_id 这个问题顺手修了吧, `然后补一个arrow largetint的nullable的处理用例 现在ut里面是非null的
Contributor
Author
|
/review |
Contributor
|
Codex automated review failed and did not complete. Error: All Codex review accounts are usage-limited; earliest retry is 2026-08-08T03:32:00Z. Please trigger /review again after that time. |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
Codex automated review failed and did not complete. Error: All Codex review accounts are usage-limited; earliest retry is 2026-08-08T03:32:00Z. Please trigger /review again after that time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #66363
Problem Summary: Successful delete bitmap cache checks repeatedly traversed both bitmaps to construct an unused error message, and nullable LARGEINT Arrow serialization formatted values before checking whether rows were null. Reuse the computed bitmap cardinalities, construct the mismatch message only on failure, and format LARGEINT values only for non-null rows.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)